From 2ca1839d77956371d2af384a13f2cb8bd9981fcd Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Sun, 1 Aug 2021 15:33:45 -0700 Subject: [PATCH] shell: add `volume.deleteEmpty` command --- weed/command/scaffold/master.toml | 1 + weed/shell/command_volume_delete_empty.go | 69 +++++++++++++++++++++++ 2 files changed, 70 insertions(+) create mode 100644 weed/shell/command_volume_delete_empty.go diff --git a/weed/command/scaffold/master.toml b/weed/command/scaffold/master.toml index 60a7dbcfc..9acefe69e 100644 --- a/weed/command/scaffold/master.toml +++ b/weed/command/scaffold/master.toml @@ -11,6 +11,7 @@ scripts = """ ec.encode -fullPercent=95 -quietFor=1h ec.rebuild -force ec.balance -force + volume.deleteEmpty volume.balance -force volume.fix.replication unlock diff --git a/weed/shell/command_volume_delete_empty.go b/weed/shell/command_volume_delete_empty.go new file mode 100644 index 000000000..07c6d5b2c --- /dev/null +++ b/weed/shell/command_volume_delete_empty.go @@ -0,0 +1,69 @@ +package shell + +import ( + "flag" + "github.com/chrislusf/seaweedfs/weed/pb/master_pb" + "io" + "log" + "time" + + "github.com/chrislusf/seaweedfs/weed/storage/needle" +) + +func init() { + Commands = append(Commands, &commandVolumeDeleteEmpty{}) +} + +type commandVolumeDeleteEmpty struct { +} + +func (c *commandVolumeDeleteEmpty) Name() string { + return "volume.deleteEmpty" +} + +func (c *commandVolumeDeleteEmpty) Help() string { + return `delete empty volumes from all volume servers + + volume.deleteEmpty -quietFor=24h + + This command deletes all empty volumes from one volume server. + +` +} + +func (c *commandVolumeDeleteEmpty) Do(args []string, commandEnv *CommandEnv, writer io.Writer) (err error) { + + if err = commandEnv.confirmIsLocked(); err != nil { + return + } + + volDeleteCommand := flag.NewFlagSet(c.Name(), flag.ContinueOnError) + quietPeriod := volDeleteCommand.Duration("quietFor", 24*time.Hour, "select empty volumes with no recent writes, avoid newly created ones") + if err = volDeleteCommand.Parse(args); err != nil { + return nil + } + + // collect topology information + topologyInfo, _, err := collectTopologyInfo(commandEnv) + if err != nil { + return err + } + + quietSeconds := int64(*quietPeriod / time.Second) + nowUnixSeconds := time.Now().Unix() + + eachDataNode(topologyInfo, func(dc string, rack RackId, dn *master_pb.DataNodeInfo) { + for _, diskInfo := range dn.DiskInfos { + for _, v := range diskInfo.VolumeInfos { + if v.Size <= 8 && v.ModifiedAtSecond + quietSeconds < nowUnixSeconds { + log.Printf("deleting empty volume %d from %s", v.Id, dn.Id) + if deleteErr := deleteVolume(commandEnv.option.GrpcDialOption, needle.VolumeId(v.Id), dn.Id); deleteErr != nil { + err = deleteErr + } + } + } + } + }) + + return +}