From 2a6db0fd436a62afdadbb03d55e8acd51d67791a Mon Sep 17 00:00:00 2001 From: Chris Lu Date: Tue, 11 Feb 2020 09:45:02 -0800 Subject: [PATCH] volume: return 204 for unchanged file uploads fix https://github.com/chrislusf/seaweedfs/issues/1196 --- weed/server/volume_server_handlers_write.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/weed/server/volume_server_handlers_write.go b/weed/server/volume_server_handlers_write.go index cd35255e5..ac8fa4f42 100644 --- a/weed/server/volume_server_handlers_write.go +++ b/weed/server/volume_server_handlers_write.go @@ -52,9 +52,10 @@ func (vs *VolumeServer) PostHandler(w http.ResponseWriter, r *http.Request) { ret := operation.UploadResult{} _, isUnchanged, writeError := topology.ReplicatedWrite(vs.GetMaster(), vs.store, volumeId, needle, r) - // http 304 status code does not allow body + // http 204 status code does not allow body if writeError == nil && isUnchanged { - w.WriteHeader(http.StatusNotModified) + setEtag(w, needle.Etag()) + w.WriteHeader(http.StatusNoContent) return }