Merge pull request #1091 from divinerapier/fix/abused-404

fix abused 404 status code
This commit is contained in:
Chris Lu 2019-10-24 09:35:54 -07:00 committed by GitHub
commit 1b71608b3c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -32,10 +32,15 @@ func (fs *FilerServer) GetOrHeadHandler(w http.ResponseWriter, r *http.Request,
fs.listDirectoryHandler(w, r) fs.listDirectoryHandler(w, r)
return return
} }
glog.V(1).Infof("Not found %s: %v", path, err) if err == filer2.ErrNotFound {
glog.V(1).Infof("Not found %s: %v", path, err)
stats.FilerRequestCounter.WithLabelValues("read.notfound").Inc() stats.FilerRequestCounter.WithLabelValues("read.notfound").Inc()
w.WriteHeader(http.StatusNotFound) w.WriteHeader(http.StatusNotFound)
} else {
glog.V(0).Infof("Internal %s: %v", path, err)
stats.FilerRequestCounter.WithLabelValues("read.internalerror").Inc()
w.WriteHeader(http.StatusInternalServerError)
}
return return
} }