gitlab-com-seaweedfs/seaweedfs
1
0
Fork 0
mirror of https://github.com/seaweedfs/seaweedfs.git synced 2024-01-19 02:48:24 +00:00
Code Issues Projects Releases Wiki Activity

add locking on possible concurrent map access

Browse source 
fix https://github.com/chrislusf/seaweedfs/issues/328
This commit is contained in:
Chris Lu 2016-06-23 09:10:25 -07:00
parent 356b8048c5
commit 101e784577
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
weed/storage/compact_map.go
View file

@ -190,18 +190,22 @@ func (cm *CompactMap) binarySearchCompactSection(key Key) int {
// Visit visits all entries or stop if any error when visiting // Visit visits all entries or stop if any error when visiting
func (cm *CompactMap) Visit(visit func(NeedleValue) error) error { func (cm *CompactMap) Visit(visit func(NeedleValue) error) error {
for _, cs := range cm.list { for _, cs := range cm.list {
cs.RLock()
for _, v := range cs.overflow { for _, v := range cs.overflow {
if err := visit(v); err != nil { if err := visit(v); err != nil {
cs.RUnlock()
return err return err
} }
} }
for _, v := range cs.values { for _, v := range cs.values {
if _, found := cs.overflow[v.Key]; !found { if _, found := cs.overflow[v.Key]; !found {
if err := visit(v); err != nil { if err := visit(v); err != nil {
cs.RUnlock()
return err return err
} }
} }
} }
cs.RUnlock()
} }
return nil return nil
} }