mirror of
https://github.com/docker-mailserver/docker-mailserver.git
synced 2024-01-19 02:48:50 +00:00
e9f04cf8a7
* chore: Adjust default DKIM size (`open-dkim`) from 4096-bit to 2048-bit 4096-bit is excessive in size for DKIM key. 2048-bit is plenty. * chore: Additional revisions to `open-dkim` command help output - The examples use `keysize 2048`, but as that's the new default it makes sense to change that. - Other help text was also revised. - Last example for domains did not need to demonstrate the other options. Changed example domains to more appropriate values. * docs: Revise DKIM docs Primarily for the change in default key size, but does revise some text to better communicate to the user. - While the referenced RFC advises 512-bit to 2048-bit key size, we now explicitly discourage `512-bit` as it's not secure. `1024-bit` is still likely safe for most, but `2048-bit` is a good default for those not rotating their keys. - Adjusted the domains example to match the new `setup config dkim domain` domains example. - Tip for changing default key size changed to "info" with added clarity of lowering security or increasing it (excessively). - Rspamd section is minor formatting changes, with the exception of clarifying the "main domain" for the mail accounts is assumed as the DMS FQDN with any subdomain (like `mail.`) stripped away. This is not great, but a legacy issue that needs to be addressed in future. - `docs-rspamd-override-d` ref removed, and usage replaced with equivalent ref `docs-rspamd-config-dropin`, while `docs-rspamd-config-declarative` ref was not in use and also removed. - Revised the `<selector>.txt` DNS formatting info section to better communicate with the reader. Additionally it had mixed usage of default `mail` and custom `dkim-rsa` selectors (_file content and output_). * docs: Sync DKIM commands help messages and update DKIM docs for LDAP - Adopt the help options format style from the `rspamd-dkim` into `open-dkim` command. And convert `./setup.sh` to `setup`. `selector` option has been implemented. for a while now. - Update `rspamd-dkim` examples help output to align with `open-dkim` command examples. - Give both DKIM command tools a consistent description. The two tools differ in support for the `domain` option (_implicit domain sourcing for default account provisioner, and support for multiple domains as input_). - DKIM docs for LDAP domain support revised to better communicate when explicit domain config is necessary. * tests: Adjust test-cases for `setup config dkim` change `rspamd_dkim.bats`: - Update assert for command help output. - Don't bother creating a DKIM key at 512-bit size. `setup_cli.bats`: - Update assert for command help output of the `setup config dkim` (OpenDKIM) command. * docs: Update DKIM section for large keys to newer RFC The linked discussion from 2021 does mention this updated RFC over the original. That removes outdated advice about `512-bit` key length support. The discussion link is still kept to reference a comment for the reader to better understand the security strength of 2048-bit RSA keys and why larger keys are not worthwhile, especially for DKIM. * docs: Extract out common DKIM generation command from content tabs Should be fine to be DRY here, not specific to `open-dkim` or `rspamd` generation/support. Previously rspamd lacked support of an equivalent command in DMS. * docs: DKIM refactoring - Shifted out the info admonition on key size advice out of the content tabs as it's now generic information. - Indented the 4096-bit warning into this, which is less of a concern as the default for our DKIM generation tools is consistently 2048-bit now. - Reworked the LDAP and Rspamd multi-domain advice. To avoid causing a bad diff, these sections haven't been moved/merged yet. * docs: Revise DKIM docs Advice for managing domains individually with LDAP and Rspamd extracted out of the content tabs. Default domain behaviour explained with extra info about OpenDKIM + FILE provisioner sourcing extra domains implicitly.
172 lines
5.5 KiB
Bash
Executable file
172 lines
5.5 KiB
Bash
Executable file
#!/bin/bash
|
|
|
|
# shellcheck source=../scripts/helpers/index.sh
|
|
source /usr/local/bin/helpers/index.sh
|
|
|
|
if [[ -f /etc/dms-settings ]] && [[ $(_get_dms_env_value 'ENABLE_RSPAMD') -eq 1 ]]; then
|
|
/usr/local/bin/rspamd-dkim "${@}"
|
|
exit
|
|
fi
|
|
|
|
KEYSIZE=2048
|
|
SELECTOR=mail
|
|
DOMAINS=
|
|
|
|
function __usage() {
|
|
printf '%s' "${PURPLE}OPEN-DKIM${RED}(${YELLOW}8${RED})
|
|
|
|
${ORANGE}NAME${RESET}
|
|
open-dkim - Configure DKIM (DomainKeys Identified Mail)
|
|
|
|
${ORANGE}SYNOPSIS${RESET}
|
|
setup config dkim [ OPTIONS${RED}...${RESET} ]
|
|
|
|
${ORANGE}DESCRIPTION${RESET}
|
|
Creates DKIM keys and configures them within DMS for OpenDKIM.
|
|
OPTIONS can be used when your requirements are not met by the defaults.
|
|
When not using 'ACCOUNT_PROVISIONER=FILE' (default), you may need to explicitly
|
|
use the 'domain' option to generate DKIM keys for your mail account domains.
|
|
|
|
${ORANGE}OPTIONS${RESET}
|
|
${BLUE}Generic Program Information${RESET}
|
|
help Print the usage information.
|
|
|
|
${BLUE}Configuration adjustments${RESET}
|
|
keysize Set the size of the keys to be generated.
|
|
Possible values: 1024, 2048 and 4096
|
|
Default: 2048
|
|
selector Set a manual selector for the key.
|
|
Default: mail
|
|
domain Provide the domain(s) for which to generate keys for.
|
|
Default: The FQDN assigned to DMS, excluding any subdomain.
|
|
'ACCOUNT_PROVISIONER=FILE' also sources domains from mail accounts.
|
|
|
|
${ORANGE}EXAMPLES${RESET}
|
|
${LWHITE}setup config dkim keysize 4096${RESET}
|
|
Creates keys with their length increased to a size of 4096-bit.
|
|
|
|
${LWHITE}setup config dkim keysize 1024 selector 2023-dkim${RESET}
|
|
Creates 1024-bit sized keys, and changes the DKIM selector to '2023-dkim'.
|
|
|
|
${LWHITE}setup config dkim domain 'example.com,another-example.com'${RESET}
|
|
Only generates DKIM keys for the specified domains: 'example.com' and 'another-example.com'.
|
|
|
|
${ORANGE}EXIT STATUS${RESET}
|
|
Exit status is 0 if command was successful. If wrong arguments are provided or arguments contain
|
|
errors, the script will exit early with exit status 2.
|
|
|
|
"
|
|
}
|
|
|
|
_require_n_parameters_or_print_usage 0 "${@}"
|
|
|
|
while [[ ${#} -gt 0 ]]; do
|
|
case "${1}" in
|
|
( 'keysize' )
|
|
if [[ -n ${2+set} ]]; then
|
|
KEYSIZE="${2}"
|
|
shift
|
|
shift
|
|
else
|
|
_exit_with_error "No keysize provided after 'keysize' argument"
|
|
fi
|
|
;;
|
|
|
|
( 'selector' )
|
|
if [[ -n ${2+set} ]]; then
|
|
# shellcheck disable=SC2034
|
|
SELECTOR="${2}"
|
|
shift
|
|
shift
|
|
else
|
|
_exit_with_error "No selector provided after 'selector' argument"
|
|
fi
|
|
;;
|
|
|
|
( 'domain' )
|
|
if [[ -n ${2+set} ]]; then
|
|
DOMAINS="${2}"
|
|
shift
|
|
shift
|
|
else
|
|
_exit_with_error "No domain(s) provided after 'domain' argument"
|
|
fi
|
|
;;
|
|
|
|
( * )
|
|
__usage
|
|
_exit_with_error "Unknown options '${1}' ${2:+and \'${2}\'}"
|
|
;;
|
|
|
|
esac
|
|
done
|
|
|
|
DATABASE_VHOST='/tmp/vhost.dkim'
|
|
# Prepare a file with one domain per line:
|
|
function _generate_domains_config() {
|
|
local TMP_VHOST='/tmp/vhost.dkim.tmp'
|
|
|
|
# Generate the default vhost (equivalent to /etc/postfix/vhost),
|
|
# unless CLI arg DOMAINS provided an alternative list to use instead:
|
|
if [[ -z ${DOMAINS} ]]; then
|
|
_obtain_hostname_and_domainname
|
|
# uses TMP_VHOST:
|
|
_vhost_collect_postfix_domains
|
|
else
|
|
tr ',' '\n' <<< "${DOMAINS}" >"${TMP_VHOST}"
|
|
fi
|
|
|
|
# uses DATABASE_VHOST + TMP_VHOST:
|
|
_create_vhost
|
|
}
|
|
|
|
_generate_domains_config
|
|
if [[ ! -s ${DATABASE_VHOST} ]]; then
|
|
_log 'warn' 'No entries found, no keys to make'
|
|
exit 0
|
|
fi
|
|
|
|
while read -r DKIM_DOMAIN; do
|
|
mkdir -p "/tmp/docker-mailserver/opendkim/keys/${DKIM_DOMAIN}"
|
|
|
|
if [[ ! -f "/tmp/docker-mailserver/opendkim/keys/${DKIM_DOMAIN}/${SELECTOR}.private" ]]; then
|
|
_log 'info' "Creating DKIM private key '/tmp/docker-mailserver/opendkim/keys/${DKIM_DOMAIN}/${SELECTOR}.private'"
|
|
|
|
opendkim-genkey \
|
|
--bits="${KEYSIZE}" \
|
|
--subdomains \
|
|
--domain="${DKIM_DOMAIN}" \
|
|
--selector="${SELECTOR}" \
|
|
--directory="/tmp/docker-mailserver/opendkim/keys/${DKIM_DOMAIN}"
|
|
fi
|
|
|
|
# write to KeyTable if necessary
|
|
KEYTABLEENTRY="${SELECTOR}._domainkey.${DKIM_DOMAIN} ${DKIM_DOMAIN}:${SELECTOR}:/etc/opendkim/keys/${DKIM_DOMAIN}/${SELECTOR}.private"
|
|
if [[ ! -f "/tmp/docker-mailserver/opendkim/KeyTable" ]]; then
|
|
_log 'debug' 'Creating DKIM KeyTable'
|
|
echo "${KEYTABLEENTRY}" >/tmp/docker-mailserver/opendkim/KeyTable
|
|
else
|
|
if ! grep -q "${KEYTABLEENTRY}" "/tmp/docker-mailserver/opendkim/KeyTable"; then
|
|
echo "${KEYTABLEENTRY}" >>/tmp/docker-mailserver/opendkim/KeyTable
|
|
fi
|
|
fi
|
|
|
|
# write to SigningTable if necessary
|
|
SIGNINGTABLEENTRY="*@${DKIM_DOMAIN} ${SELECTOR}._domainkey.${DKIM_DOMAIN}"
|
|
if [[ ! -f /tmp/docker-mailserver/opendkim/SigningTable ]]; then
|
|
_log 'debug' 'Creating DKIM SigningTable'
|
|
echo "*@${DKIM_DOMAIN} ${SELECTOR}._domainkey.${DKIM_DOMAIN}" >/tmp/docker-mailserver/opendkim/SigningTable
|
|
else
|
|
if ! grep -q "${SIGNINGTABLEENTRY}" /tmp/docker-mailserver/opendkim/SigningTable; then
|
|
echo "${SIGNINGTABLEENTRY}" >>/tmp/docker-mailserver/opendkim/SigningTable
|
|
fi
|
|
fi
|
|
done < <(_get_valid_lines_from_file "${DATABASE_VHOST}")
|
|
|
|
# create TrustedHosts if missing
|
|
if [[ -d /tmp/docker-mailserver/opendkim ]] && [[ ! -f /tmp/docker-mailserver/opendkim/TrustedHosts ]]; then
|
|
_log 'debug' 'Creating DKIM TrustedHosts'
|
|
echo "127.0.0.1" >/tmp/docker-mailserver/opendkim/TrustedHosts
|
|
echo "localhost" >>/tmp/docker-mailserver/opendkim/TrustedHosts
|
|
fi
|