mirror of
https://github.com/docker-mailserver/docker-mailserver.git
synced 2024-01-19 02:48:50 +00:00
57aeb6db2a
See the associated PR for more detailed commentary on specific changes.
### Commands refactored:
- User (**All:** add / list / update / del + _dovecot-master variants_)
- Quota (**All:** set / del)
- Virtual Alias (**All:** add / list /del)
- Relay (**All:** add-relayhost / add-sasl / exclude-domain)
### Overall changes involve:
- **Fairly common structure:**
- `_main` method at the top provides an overview of logical steps:
- After all methods are declared beneath it (_and imported from the new `helpers/database/db.sh`_), the `_main` is called at the bottom of the file.
- `delmailuser` additionally processes option support for `-y` prior to calling `_main`.
- `__usage` is now consistent with each of these commands, along with the `help` command.
- Most logic delegated to new helper scripts. Some duplicate content remains on the basis that it's low-risk to maintenance and avoids less hassle to jump between files to check a single line, usually this is arg validation.
- Error handling should be more consistent, along with var names (_no more `USER`/`EMAIL`/`FULL_EMAIL` to refer to the same expected value_).
- **Three new management scripts** (in `helpers/database/manage/`) using a common structure for managing changes to their respective "Database" config file.
- `postfix-accounts.sh` unified not only add and update commands, but also all the dovecot-master versions, a single password call for all 4 of them, with a 5th consumer of the password prompt from the relay command `addsaslpassword`.
- These scripts delegate actual writes to `helpers/database/db.sh` which provides a common API to support the changes made.
- This is more verbose/complex vs the current inline operations each command currently has, as it provides generic support instead of slightly different variations being maintained, along with handling some edge cases that existed and would lead to bugs (notably substring matches).
- Centralizing changes here seems wiser than scattered about. I've tried to make it easy to grok, hopefully it's not worse than the current situation.
- List operations were kept in their respective commands, `db.sh` is only really managing writes. I didn't see a nice way for removing the code duplication for list commands as the duplication was fairly minimal, especially for `listalias` and `listdovecotmasteruser` which were quite simple in their differences in the loop body.
- `listmailuser` and `delmailuser` also retain methods exclusive to respective commands, I wasn't sure if there was any benefit to move those, but they were refactored.
|
||
|---|---|---|
| .. | ||
| bats@54e965fa9d | ||
| config | ||
| docker-openldap | ||
| linting | ||
| test-files | ||
| test_helper | ||
| default_relay_host.bats | ||
| dovecot_inet_protocol.bats | ||
| helper-functions.bats | ||
| mail_changedetector.bats | ||
| mail_disabled_clamav_spamassassin.bats | ||
| mail_dnsbl.bats | ||
| mail_fail2ban.bats | ||
| mail_fetchmail.bats | ||
| mail_fetchmail_parallel.bats | ||
| mail_hostname.bats | ||
| mail_lmtp_ip.bats | ||
| mail_pop3.bats | ||
| mail_postfix_inet.bats | ||
| mail_postscreen.bats | ||
| mail_privacy.bats | ||
| mail_quotas_disabled.bats | ||
| mail_smtponly.bats | ||
| mail_spam_bounced.bats | ||
| mail_spam_junk_folder.bats | ||
| mail_special_use_folders.bats | ||
| mail_ssl_letsencrypt.bats | ||
| mail_ssl_manual.bats | ||
| mail_time.bats | ||
| mail_tls_dhparams.bats | ||
| mail_undef_spam_subject.bats | ||
| mail_with_imap.bats | ||
| mail_with_ldap.bats | ||
| mail_with_mdbox.bats | ||
| mail_with_postgrey.bats | ||
| mail_with_postgrey_disabled_by_default.bats | ||
| mail_with_relays.bats | ||
| mail_with_sdbox.bats | ||
| no_container.bats | ||
| open_dkim.bats | ||
| permit_docker.bats | ||
| security_tls_cipherlists.bats | ||
| sedfile.bats | ||
| setup-cli.bats | ||
| test_helper.bats | ||
| tests.bats | ||