mirror of
https://github.com/docker-mailserver/docker-mailserver.git
synced 2024-01-19 02:48:50 +00:00
Added TODO as per code review and removed one sleep
This commit is contained in:
parent
573609e011
commit
21c89b3364
|
@ -1216,11 +1216,6 @@ load 'test_helper/bats-assert/load'
|
||||||
|
|
||||||
|
|
||||||
@test "checking user login: predefined user can login" {
|
@test "checking user login: predefined user can login" {
|
||||||
# This should really not be necessary, but this test sometimes fails, probably due to timing
|
|
||||||
if ! (docker exec mail doveadm auth test -x service=smtp pass@localhost.localdomain 'may be \a `p^a.*ssword' >/dev/null); then
|
|
||||||
sleep 60
|
|
||||||
fi
|
|
||||||
|
|
||||||
result=$(docker exec mail doveadm auth test -x service=smtp pass@localhost.localdomain 'may be \a `p^a.*ssword' | grep 'auth succeeded')
|
result=$(docker exec mail doveadm auth test -x service=smtp pass@localhost.localdomain 'may be \a `p^a.*ssword' | grep 'auth succeeded')
|
||||||
[ "$result" = "passdb: pass@localhost.localdomain auth succeeded" ]
|
[ "$result" = "passdb: pass@localhost.localdomain auth succeeded" ]
|
||||||
}
|
}
|
||||||
|
@ -1446,6 +1441,7 @@ load 'test_helper/bats-assert/load'
|
||||||
|
|
||||||
if ! (docker exec mail doveadm auth test -x service=smtp setup_email_add@example.com 'test_password' >/dev/null); then
|
if ! (docker exec mail doveadm auth test -x service=smtp setup_email_add@example.com 'test_password' >/dev/null); then
|
||||||
# Possibly the cron job has not had time to run yet, waiting a while is better than a false alarm
|
# Possibly the cron job has not had time to run yet, waiting a while is better than a false alarm
|
||||||
|
# TODO find a better way to detect when the container is ready
|
||||||
sleep 30
|
sleep 30
|
||||||
fi
|
fi
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue